Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate debug in IDEA tasks #1918

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

3flex
Copy link
Member

@3flex 3flex commented Sep 15, 2019

These parameters don't do anything in the IDEA tasks, so are deprecated and can be removed in future.

@arturbosch arturbosch added this to the 1.0.2 milestone Sep 16, 2019
@arturbosch arturbosch merged commit fb134ca into detekt:master Sep 16, 2019
@3flex 3flex deleted the deprecate-debug branch September 16, 2019 07:59
@schalkms
Copy link
Member

This seems to break the current master build.

sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
@3flex
Copy link
Member Author

3flex commented Sep 17, 2019

The error on the log is confusing... Complains about missing class "org/jetbrains/kotlin/config/JvmTarget" but only on Java 8 on Travis.

I'll revert this then let's see what happens.

3flex added a commit that referenced this pull request Sep 17, 2019
@3flex
Copy link
Member Author

3flex commented Sep 17, 2019

Reverting didn't fix it, see the build error on #1924.

I'm closing that and opening a new issue for the build failure.

@arturbosch arturbosch modified the milestones: 1.0.2, 1.1.0 Sep 17, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@3flex 3flex restored the deprecate-debug branch July 29, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants