Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UndocumentedPublicProperty rule - closes #1670 #1923

Merged
merged 5 commits into from
Oct 8, 2019
Merged

Add UndocumentedPublicProperty rule - closes #1670 #1923

merged 5 commits into from
Oct 8, 2019

Conversation

schalkms
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.2.0 milestone Sep 17, 2019
@arturbosch arturbosch modified the milestones: 1.2.0, 1.1.0 Oct 4, 2019
@arturbosch
Copy link
Member

Unfortunately I messed it up with the GitHub gui to fix the conflicts :(

@arturbosch arturbosch modified the milestones: 1.1.0, 1.2.0 Oct 4, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4e9dc71). Click here to learn what that means.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1923   +/-   ##
=========================================
  Coverage          ?   80.71%           
  Complexity        ?     1988           
=========================================
  Files             ?      330           
  Lines             ?     5585           
  Branches          ?     1020           
=========================================
  Hits              ?     4508           
  Misses            ?      538           
  Partials          ?      539
Impacted Files Coverage Δ Complexity Δ
...turbosch/detekt/rules/documentation/CommentUtil.kt 100% <ø> (ø) 0 <0> (?)
.../rules/documentation/UndocumentedPublicFunction.kt 77.77% <100%> (ø) 9 <0> (?)
...sch/detekt/rules/providers/CommentSmellProvider.kt 100% <100%> (ø) 3 <0> (?)
.../rules/documentation/UndocumentedPublicProperty.kt 87.5% <87.5%> (ø) 10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9dc71...e196544. Read the comment docs.

@arturbosch arturbosch merged commit b90c755 into detekt:master Oct 8, 2019
@schalkms schalkms deleted the feature-#1670-UndocumentedPublicProp branch November 8, 2019 18:12
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Rebase

* Update documentation

* Put back visibility kinds inside testcase

* Replace tabs with spaces in test snippets

* Fix merged test case
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Rebase

* Update documentation

* Put back visibility kinds inside testcase

* Replace tabs with spaces in test snippets

* Fix merged test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants