Enable more rules in failfast #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables more rules when running the detekt task on detekt itself. This PR fixes warnings that are reported by the newly activated rules. Related issue #1911
|
I didn't activate the |
schalkms
commented
Sep 18, 2019
| @@ -6,6 +6,7 @@ import org.gradle.api.tasks.OutputDirectory | |||
| import org.gradle.api.tasks.PathSensitive | |||
| import org.gradle.api.tasks.PathSensitivity | |||
|
|
|||
| @Suppress("UnsafeCallOnNullableType") | |||
| open class IdeaExtension { | |||
There was a problem hiding this comment.
require(path != null)
println(path!!) // Kotlin compiler can't infer the null check in require before
...rc/main/kotlin/io/gitlab/arturbosch/detekt/rules/documentation/CommentOverPrivateFunction.kt
Show resolved
Hide resolved
...rc/main/kotlin/io/gitlab/arturbosch/detekt/rules/documentation/CommentOverPrivateProperty.kt
Show resolved
Hide resolved
arturbosch
approved these changes
Sep 26, 2019
|
Blocked by #1952 |
arturbosch
pushed a commit
that referenced
this pull request
Oct 15, 2019
This may break users baseline. See #1935
|
I've merged #1952 . Feel free to rebase this when you have time 👍 |
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
This may break users baseline. See detekt#1935
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Enable more rules in failfast This enables more rules when running the detekt task on detekt itself. This PR fixes warnings that are reported by the newly activated rules. Related issue detekt#1911 * Add ArrayPrimitive rule to failfast * Fix issues reported in detekt task
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
This may break users baseline. See detekt#1935
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Enable more rules in failfast This enables more rules when running the detekt task on detekt itself. This PR fixes warnings that are reported by the newly activated rules. Related issue detekt#1911 * Add ArrayPrimitive rule to failfast * Fix issues reported in detekt task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables more rules when running the detekt task on detekt itself.
This PR fixes warnings that are reported by the newly activated rules.
Related issue #1911