Fix SpacingBetweenPackageAndImports issue for scripts without packages #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
reviewed
Sep 25, 2019
...s/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/SpacingBetweenPackageAndImports.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
============================================
- Coverage 80.75% 80.74% -0.02%
+ Complexity 2001 2000 -1
============================================
Files 329 329
Lines 5587 5587
Branches 1038 1038
============================================
- Hits 4512 4511 -1
Misses 537 537
- Partials 538 539 +1
Continue to review full report at Codecov.
|
3flex
approved these changes
Sep 25, 2019
arturbosch
approved these changes
Sep 26, 2019
This rule doesn't use a mutable variable anymore.
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Oct 1, 2019
detekt#1947) * Revert "Fix SpacingBetweenPackageAndImports issue for KTS (detekt#1939)" This reverts commit faff9f4. * Fix SpacingBetweenPackageAndImports issue for scripts without packages Both a Kotlin file and a Kotlin script can be declared with and without a package declaration. This commit checks if the class even contains a package declaration for both .kt and .kts files. Closes detekt#1937 * Use more sophisticated package check * Refactor SpacingBetweenPackageAndImports rule This rule doesn't use a mutable variable anymore.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
detekt#1947) * Revert "Fix SpacingBetweenPackageAndImports issue for KTS (detekt#1939)" This reverts commit faff9f4. * Fix SpacingBetweenPackageAndImports issue for scripts without packages Both a Kotlin file and a Kotlin script can be declared with and without a package declaration. This commit checks if the class even contains a package declaration for both .kt and .kts files. Closes detekt#1937 * Use more sophisticated package check * Refactor SpacingBetweenPackageAndImports rule This rule doesn't use a mutable variable anymore.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
detekt#1947) * Revert "Fix SpacingBetweenPackageAndImports issue for KTS (detekt#1939)" This reverts commit faff9f4. * Fix SpacingBetweenPackageAndImports issue for scripts without packages Both a Kotlin file and a Kotlin script can be declared with and without a package declaration. This commit checks if the class even contains a package declaration for both .kt and .kts files. Closes detekt#1937 * Use more sophisticated package check * Refactor SpacingBetweenPackageAndImports rule This rule doesn't use a mutable variable anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both a Kotlin file and a Kotlin script can be declared with and without
a package declaration. This commit checks if the class even contains a
package declaration for both .kt and .kts files.
Closes #1937