Allow regex configuration support for Forbidden Import rule #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
requested changes
Oct 1, 2019
| @@ -21,6 +21,8 @@ import org.jetbrains.kotlin.psi.KtImportDirective | |||
| * </noncompliant> | |||
| * | |||
| * @configuration imports - imports which should not be used (default: `''`) | |||
| * @configuration forbiddenPatterns - reports imports which match the specified regular expression. | |||
| For example `net.*R`. (default: `""`) | |||
There was a problem hiding this comment.
This should probably not be on a new line
sowmyav24
force-pushed
the
regex-support-for-forbidden-import
branch
from
43b5bfc
to
a5cebcc
Compare
sowmyav24
force-pushed
the
regex-support-for-forbidden-import
branch
from
a5cebcc
to
d6943e0
Compare
schalkms
reviewed
Oct 1, 2019
| @@ -53,7 +56,12 @@ class ForbiddenImport(config: Config = Config.empty) : Rule(config) { | |||
| } | |||
| } | |||
|
|
|||
| private fun containsForbiddenPattern(import: String): Boolean { | |||
| return forbiddenPatterns.pattern.isNotEmpty() && forbiddenPatterns.containsMatchIn(import) | |||
There was a problem hiding this comment.
You could use the shorthand syntax for this function.
| } | ||
|
|
||
| it("should report import when it matches any one of the pattern") { | ||
| val findings = |
There was a problem hiding this comment.
You could remove this test, because essentially we test the regex engine here. One test that asserts the positive case is enough.
schalkms
approved these changes
Oct 2, 2019
|
This is awesome. Thanks @sowmyav24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1430
forbiddenPatternsto specify forbidden regex for imports.