Ignore FunctionOnlyReturningConstant for allowed annotations #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkms
reviewed
Oct 2, 2019
|
|
||
| it("does not report excluded annotated function which returns a constant") { | ||
| val code = """ | ||
| import jdk.nashorn.internal.ir.annotations.Ignore |
There was a problem hiding this comment.
This is the reason why the build fails on some machines when compiling the test snippet. Please remove this import here.
There was a problem hiding this comment.
Yes, replaced with kotlin.SinceKotlin
| """.trimIndent() | ||
| val config = TestConfig(mapOf("excludeAnnotatedFunction" to "jdk.nashorn.internal.ir.annotations.Ignore")) | ||
| val rule = FunctionOnlyReturningConstant(config) | ||
| assertThat(rule.compileAndLint(code)).hasSize(0) |
There was a problem hiding this comment.
nit
Suggested change
| assertThat(rule.compileAndLint(code)).hasSize(0) | |
| assertThat(rule.compileAndLint(code)).isEmpty() |
|
|
||
| it("does not report excluded annotated function which returns a constant") { | ||
| val code = """ | ||
| import jdk.nashorn.internal.ir.annotations.Ignore |
There was a problem hiding this comment.
You could use the kotlin.SinceKotlin annotation for testing purposes.
|
Thanks! I like this config option. |
schalkms
approved these changes
Oct 3, 2019
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…1968) * Ignore FunctionOnlyReturningConstant for allowed annotations * Refactor tests
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…1968) * Ignore FunctionOnlyReturningConstant for allowed annotations * Refactor tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1313
excludeAnnotatedFunctionsto provide a list of annotations that can disableFunctionOnlyReturningConstantcheckdagger.Provides