Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ignoreLabeled config for ReturnFromFinally #1973

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Introduce ignoreLabeled config for ReturnFromFinally #1973

merged 1 commit into from
Oct 4, 2019

Conversation

sowmyav24
Copy link
Contributor

Fixes #1467

  • Introduced ignoreLabeled configuration for ReturnFromFinally rule which is false by default.

schalkms
schalkms approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!
The PR looks good to merge.

@arturbosch arturbosch added this to the 1.1.0 milestone Oct 4, 2019
@arturbosch arturbosch merged commit f7e3ce6 into detekt:master Oct 4, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@sowmyav24 @smyachenkov
Introduce ignoreLabeled config for ReturnFromFinally (detekt#1973)
3ac2c66
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@sowmyav24
Introduce ignoreLabeled config for ReturnFromFinally (detekt#1973)
20929ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

@arturbosch arturbosch arturbosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

return@ should be allowed for ReturnFromFinally
3 participants
@sowmyav24 @arturbosch @schalkms