Use config parameter for UseIfInsteadOfWhen rule #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deactivating the UseIfInsteadOfWhen rule had no effect, since the config parameter was missing for the rule. Fixes #1986
schalkms
commented
Oct 5, 2019
This test checks if a valid config has been passed to all detekt rules. This prevents bugs like in #1986 form happening.
Reason: Class.newInstance() bypasses exception checking; prefer getDeclaredConstructor().newInstance() http://errorprone.info/bugpattern/ClassNewInstance
|
should now also run on > Java8 |
sschuberth
approved these changes
Oct 6, 2019
3flex
approved these changes
Oct 6, 2019
|
BTW, the 1.1.0 tag in Git seems to be wrong now as it includes this fix, however the issue only occurred after the 1.1.0 release. |
|
Yeah, I forgot the github release tag. |
|
Well, yes, you can delete the wrong remote tag and push a new one under the same name, but of course that will not fix the local tags for anyone who fetched in between... |
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Use config parameter for UseIfInsteadOfWhen rule Deactivating the UseIfInsteadOfWhen rule had no effect, since the config parameter was missing for the rule. Fixes detekt#1986 * Add RuleProvider config test This test checks if a valid config has been passed to all detekt rules. This prevents bugs like in detekt#1986 form happening. * Don't use deprecated class.newInstance() for Java9 Reason: Class.newInstance() bypasses exception checking; prefer getDeclaredConstructor().newInstance() http://errorprone.info/bugpattern/ClassNewInstance
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Use config parameter for UseIfInsteadOfWhen rule Deactivating the UseIfInsteadOfWhen rule had no effect, since the config parameter was missing for the rule. Fixes detekt#1986 * Add RuleProvider config test This test checks if a valid config has been passed to all detekt rules. This prevents bugs like in detekt#1986 form happening. * Don't use deprecated class.newInstance() for Java9 Reason: Class.newInstance() bypasses exception checking; prefer getDeclaredConstructor().newInstance() http://errorprone.info/bugpattern/ClassNewInstance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deactivating the UseIfInsteadOfWhen rule had no effect, since the config
parameter was missing for the rule.
Fixes #1986