Allow the user to collapse the rules in the html report #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbosch
approved these changes
Oct 10, 2019
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Fix tests * Use kotlinx.html instead of HtmlSnippet * Use kotlin forEach * Split code in different functions * ruleFindings can't be empty * Use forEach instead of for * Add summary tag * Allow the user to collapse the rules
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Fix tests * Use kotlinx.html instead of HtmlSnippet * Use kotlin forEach * Split code in different functions * ruleFindings can't be empty * Use forEach instead of for * Add summary tag * Allow the user to collapse the rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tired of scroll to find a rule while I was working on the snippet feature. This PR kind of fix this.
It allows the user to collapse one rule:
As a previuos step i refacotred the
HtmlOutputReportclass to avoid the nesting and simplify the code.I know that this PR will generate conflicts with #1975 but I'm ok with that. The refactor that I did here will help me in the other.