Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text location: MandatoryBracesIfStatements #2051

Merged
merged 5 commits into from
Oct 28, 2019
Merged

Improve text location: MandatoryBracesIfStatements #2051

merged 5 commits into from
Oct 28, 2019

Conversation

BraisGabin
Copy link
Member

I improved the text location and fix a bug when we were raising 2 findings but there was only one error.

@arturbosch arturbosch added this to the 1.2.0 milestone Oct 27, 2019
@arturbosch arturbosch merged commit 0c24d9e into detekt:master Oct 28, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Split MandatoryBracesIfStatementsSpec in smaller tests

* Add missing tests at MandatoryBracesIfStatementsSpec

* Apply DRY at MandatoryBracesIfStatements

* Fix double finding when there's only one issue at MandatoryBracesIfStatements

* Improve TextLocation for MandatoryBracesIfStatements
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Split MandatoryBracesIfStatementsSpec in smaller tests

* Add missing tests at MandatoryBracesIfStatementsSpec

* Apply DRY at MandatoryBracesIfStatements

* Fix double finding when there's only one issue at MandatoryBracesIfStatements

* Improve TextLocation for MandatoryBracesIfStatements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants