Improve text location: MatchingDeclarationName #2062
Conversation
| @@ -97,6 +104,14 @@ internal class MatchingDeclarationNameSpec : Spek({ | |||
| assertThat(findings).hasLocationStrings("'object O' at (1,1) in /Objects.kt") | |||
| } | |||
|
|
|||
| it("should not pass for object declaration even with suppress on the object") { | |||
| val ktFile = compileContentForTest("""@Suppress("MatchingDeclarationName") object O""") | |||
| ktFile.name = "Objects.kt" | |||
There was a problem hiding this comment.
We could give the compileContentForTest function or even the (compileAnd)Lint functions a second parameter filename so we can skip setting up the name for the KtFile here?
There was a problem hiding this comment.
I just did a little research... Why do we use the functions inside CompileExtensions.kt? They provide nothing... And why the file is called extensions if they are not extension functions?
I did a fast fix for this PR but I can create (later) a new PR removing that file and using KtTestCompiler directly. What do you think?
There was a problem hiding this comment.
True the naming is kinda odd.
The intention was to not use the KtTestCompiler directly. compileContentForTest is more concise for tests.
Codecov Report
@@ Coverage Diff @@
## master #2062 +/- ##
=========================================
Coverage ? 80.36%
Complexity ? 2015
=========================================
Files ? 332
Lines ? 5662
Branches ? 1044
=========================================
Hits ? 4550
Misses ? 559
Partials ? 553
Continue to review full report at Codecov.
|
* Use trimIndent() in MatchingDeclarationNameSpec * Add test to ensure that @Suppress works in MatchingDeclarationName * Improve TextLocation for MatchingDeclarationName * Allow to pass the Filename directly to compileContentForTest
* Use trimIndent() in MatchingDeclarationNameSpec * Add test to ensure that @Suppress works in MatchingDeclarationName * Improve TextLocation for MatchingDeclarationName * Allow to pass the Filename directly to compileContentForTest
No description provided.