Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate properties on Entity - Closes #2014 #2072

Merged
merged 2 commits into from
Nov 3, 2019

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.2.0 milestone Nov 2, 2019
@arturbosch arturbosch force-pushed the deprecations-on-entity branch from 04d852e to 9a1a040 Compare November 2, 2019 18:04
@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

Merging #2072 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2072      +/-   ##
============================================
- Coverage     80.55%   80.53%   -0.02%     
+ Complexity     1992     1991       -1     
============================================
  Files           332      332              
  Lines          5707     5707              
  Branches       1044     1044              
============================================
- Hits           4597     4596       -1     
- Misses          554      555       +1     
  Partials        556      556
Impacted Files Coverage Δ Complexity Δ
...kotlin/io/gitlab/arturbosch/detekt/api/Findings.kt 60% <ø> (ø) 0 <0> (ø) ⬇️
...n/kotlin/io/gitlab/arturbosch/detekt/api/Entity.kt 84.61% <ø> (-7.7%) 4 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8111c3...9a1a040. Read the comment docs.

@arturbosch arturbosch merged commit 8b11f1d into master Nov 3, 2019
@arturbosch arturbosch deleted the deprecations-on-entity branch November 3, 2019 09:14
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Deprecate properties on Entity - Closes detekt#2014

* Suppress deprecations for build to pass
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Deprecate properties on Entity - Closes detekt#2014

* Suppress deprecations for build to pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants