Skip to content

Fix TrailingWhitespace reported position #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2019
Merged

Fix TrailingWhitespace reported position #2078

merged 4 commits into from
Nov 16, 2019

Conversation

BraisGabin
Copy link
Member

This PR fixes #1979

@schalkms
Copy link
Member

schalkms commented Nov 7, 2019

Thanks for picking this up!
I just scrolled quickly over the changes. At first glance, I'd say that this is a nice fix.
I'll take a closer look at this PR tomorrow.

schalkms
schalkms approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arturbosch arturbosch added this to the 1.2.0 milestone Nov 14, 2019
@arturbosch arturbosch merged commit fa21d2a into detekt:master Nov 16, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@BraisGabin @smyachenkov
Fix TrailingWhitespace reported position (detekt#2078)
b29ea3b 
* Fix test in TrailingWhitespaceSpec

* Fix TrailingWhitespace reported position

* Test more negative cases for TrailingWhitespace

* Split tests
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@BraisGabin
Fix TrailingWhitespace reported position (detekt#2078)
062cd3f 
* Fix test in TrailingWhitespaceSpec

* Fix TrailingWhitespace reported position

* Test more negative cases for TrailingWhitespace

* Split tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

@BoxResin BoxResin BoxResin approved these changes

@arturbosch arturbosch arturbosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

TrailingWhitespace reports incorrect line number
4 participants
@BraisGabin @schalkms @BoxResin @arturbosch