Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license badge to README #2080

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Add license badge to README #2080

merged 1 commit into from
Nov 11, 2019

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Nov 8, 2019

No description provided.

@3flex
Copy link
Member

3flex commented Nov 9, 2019

No issue with the PR itself, but does FOSSA actually report anything useful for this repo?

It says "FOSSA does not fully support this environment yet" when clicking the link, and it doesn't report the license for any dependencies (which I thought was the idea with FOSSA). All it can do right now is report that detekt uses Apache 2.0 license, but that's clear from the license file and also shown in top right of repo homepage on Github:
image

Copy link
Member Author

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it looks to me FOSSA doesn't scan the Gradle Kotlin build script, because it doesn't support it.
I remember that there was a license obligation problem with the detekt sonar plugin.
That's the reason for having the FOSSA scan included in all detekt-* projects.
At the moment it's not very useful, I agree. However, when there's support for the Gradle Kotlin DSL the build automatically fails, when something is wrong with the licensing stuff.

@arturbosch arturbosch merged commit 478cef7 into detekt:master Nov 11, 2019
@arturbosch arturbosch added this to the 1.2.0 milestone Nov 11, 2019
@schalkms schalkms deleted the schalkms-license-badge branch November 26, 2019 22:47
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants