Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NestedBlockDepth false negative #2086

Merged
merged 3 commits into from
Nov 16, 2019

Conversation

BraisGabin
Copy link
Member

Fix #2085

I also improve the tests a bit simplifing the code and using compileAndLint()

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #2086 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2086      +/-   ##
============================================
+ Coverage     80.86%   80.86%   +<.01%     
  Complexity     2010     2010              
============================================
  Files           336      336              
  Lines          5779     5780       +1     
  Branches       1060     1060              
============================================
+ Hits           4673     4674       +1     
  Misses          546      546              
  Partials        560      560
Impacted Files Coverage Δ Complexity Δ
...rbosch/detekt/rules/complexity/NestedBlockDepth.kt 93.61% <100%> (+0.13%) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6800a8c...df827ee. Read the comment docs.

@arturbosch
Copy link
Member

Thanks again for the great PR.It kinda feels wrong to hold back all the good improvements and fixes from the community :/. I try to finish #1921 this WE and release a new version soon.

BraisGabin and others added 2 commits November 16, 2019 10:45
…/complexity/NestedBlockDepthSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
…/complexity/NestedBlockDepthSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
@BraisGabin
Copy link
Member Author

Done. Sorry for the late update. Busy days.

@schalkms schalkms merged commit 584fe66 into detekt:master Nov 16, 2019
@arturbosch arturbosch added this to the 1.2.0 milestone Nov 16, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Fix NestedBlockDepth

* Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>

* Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Fix NestedBlockDepth

* Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>

* Update detekt-rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/NestedBlockDepthSpec.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedBlockDepth false negative
4 participants