Improve naming tests #2094
Merged
Improve naming tests #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
commented
Nov 17, 2019
Comment on lines
+26
to
+31
| class C(val PARAM: String, private val PRIVATE_PARAM: String) | ||
|
|
||
| class C { | ||
| constructor(PARAM: String) {} | ||
| constructor(PARAM: String, PRIVATE_PARAM: String) {} | ||
| } |
There was a problem hiding this comment.
How does this compile? Two classes with the same name.
There was a problem hiding this comment.
Good question. Maybe the type checking step will first trigger redundant names?
Well as this is the scripting compiler everything should be checked ...
BraisGabin
commented
Nov 17, 2019
Comment on lines
11
to
20
| it("should not detect any") { | ||
| val code = """ | ||
| data class D(val i: Int, val j: Int) | ||
| fun doStuff() { | ||
| val (_, HOLY_GRAIL) = D(5, 4) | ||
| emptyMap<String, String>().forEach { _, V -> println(v) } | ||
| emptyMap<String, String>().forEach { _, V -> println(V) } | ||
| } | ||
| """ | ||
| assertThat(subject.lint(code)).isEmpty() | ||
| assertThat(NamingRules().compileAndLint(code)).isEmpty() | ||
| } |
There was a problem hiding this comment.
I'd like to Remove NamingRulesSpec and move this to its own rule spec... But I don't know which rule is related with this test.
Codecov Report
@@ Coverage Diff @@
## master #2094 +/- ##
============================================
- Coverage 80.84% 80.77% -0.07%
- Complexity 2008 2009 +1
============================================
Files 336 336
Lines 5784 5784
Branches 1059 1059
============================================
- Hits 4676 4672 -4
- Misses 546 547 +1
- Partials 562 565 +3
Continue to review full report at Codecov.
|
arturbosch
approved these changes
Nov 25, 2019
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
* Fix test names
* Add missing test in EnumNamingSpec
* Split ParameterNamingSpec
* Don't use NamingRules for the tests
* Remove the cases that are already tested
* Add more annotations Language("kotlin")
* Use compileAndLint
* Use VariableNaming instead of NamingRules
* Extract VariableNamingSpec from NamingRulesSpec
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Fix test names
* Add missing test in EnumNamingSpec
* Split ParameterNamingSpec
* Don't use NamingRules for the tests
* Remove the cases that are already tested
* Add more annotations Language("kotlin")
* Use compileAndLint
* Use VariableNaming instead of NamingRules
* Extract VariableNamingSpec from NamingRulesSpec
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Fix test names
* Add missing test in EnumNamingSpec
* Split ParameterNamingSpec
* Don't use NamingRules for the tests
* Remove the cases that are already tested
* Add more annotations Language("kotlin")
* Use compileAndLint
* Use VariableNaming instead of NamingRules
* Extract VariableNamingSpec from NamingRulesSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a general refactor in the naming tests. Split tests in different files, simplify some, fix typos, reduce the scope of others...