MemberNameEqualsClassName should ignore overridden property names too #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
============================================
+ Coverage 80.48% 80.49% +<.01%
+ Complexity 2018 2013 -5
============================================
Files 336 336
Lines 5802 5799 -3
Branches 1064 1063 -1
============================================
- Hits 4670 4668 -2
Misses 564 564
+ Partials 568 567 -1
Continue to review full report at Codecov.
|
3flex
reviewed
Nov 26, 2019
...-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/naming/MemberNameEqualsClassName.kt
Outdated
Show resolved
Hide resolved
...-rules/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/naming/MemberNameEqualsClassName.kt
Outdated
Show resolved
Hide resolved
| """ | ||
| assertThat(MemberNameEqualsClassName().compileAndLint(code)).hasSize(1) | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks like this example wasn't migrated from the existing MemberNameEqualsClassNamePositive file:
class WrongFactoryClass1 {
companion object {
fun wrongFactoryClass1() {} // reports 1 - no return type
}
}There was a problem hiding this comment.
I thought that both tests was testing exactly the same thing for that reason I removed one. I added it again.
arturbosch
approved these changes
Nov 26, 2019
|
The fail seems flaky |
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
…#2104) * Split failing tests in MemberNameEqualsClassNameSpec * Add missing test to check ignoreOverriddenFunction in MemberNameEqualsClassName * Don't use List.concat, it doesn't handle the nullables correctly * Use sequence instead of list * Ignore overridden properties too in MemberNameEqualsClassName * Update documentation * Add missing test from commit 30356f9
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…detekt#2104) * Split failing tests in MemberNameEqualsClassNameSpec * Add missing test to check ignoreOverriddenFunction in MemberNameEqualsClassName * Don't use List.concat, it doesn't handle the nullables correctly * Use sequence instead of list * Ignore overridden properties too in MemberNameEqualsClassName * Update documentation * Add missing test from commit 30356f9
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
…detekt#2104) * Split failing tests in MemberNameEqualsClassNameSpec * Add missing test to check ignoreOverriddenFunction in MemberNameEqualsClassName * Don't use List.concat, it doesn't handle the nullables correctly * Use sequence instead of list * Ignore overridden properties too in MemberNameEqualsClassName * Update documentation * Add missing test from commit 30356f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
MemberNameEqualsClassNameonly allows to ignore overridden functions. This PR change that to ignore both: functions and properties.This PR is related with this issue: #2096
In the future we should rename the flag
ignoreOverriddenFunctiontoignoreOverridden. But that's a breaking change. We are talking about that at #2096