Don't compile test snippets #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
=========================================
Coverage 80.62% 80.62%
Complexity 2015 2015
=========================================
Files 336 336
Lines 5802 5802
Branches 1057 1057
=========================================
Hits 4678 4678
Misses 563 563
Partials 561 561Continue to review full report at Codecov.
|
|
That's interesting. It works for AppVeyor but not for Travis? |
schalkms
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Thanks! This looks fine and is an improvement over the old CI behavior! If @arturbosch is okay with it, we should merge this asap.
BoxResin
approved these changes
Nov 24, 2019
|
There're some conflicts to resolve. |
If you want to check that your code in the snippets compiles you can use the flag -Pcompile-test-snippets=true in gradle
|
Rebased to fix the conflicts |
arturbosch
approved these changes
Nov 26, 2019
schalkms
added a commit
that referenced
this pull request
Nov 30, 2019
follow-up: #2105 This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable compile-snippet-tests is set to false.
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
* Don't compile the snippet codes in the test by default If you want to check that your code in the snippets compiles you can use the flag -Pcompile-test-snippets=true in gradle * Configure travis and appvenyor to compile the snippets
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
follow-up: #2105 This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable compile-snippet-tests is set to false.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Don't compile the snippet codes in the test by default If you want to check that your code in the snippets compiles you can use the flag -Pcompile-test-snippets=true in gradle * Configure travis and appvenyor to compile the snippets
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
follow-up: detekt#2105 This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable compile-snippet-tests is set to false.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Don't compile the snippet codes in the test by default If you want to check that your code in the snippets compiles you can use the flag -Pcompile-test-snippets=true in gradle * Configure travis and appvenyor to compile the snippets
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
follow-up: detekt#2105 This further speeds up detekt's CI and the tests runs on our local dev machines. The Jsr223 compiles engines aren't even created at startup anymore if the environment variable compile-snippet-tests is set to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2095
We need to check that our production is OK every time. But we don't need to check that our tests are OK every time too.
This change speeds up the tests about 2.5 times.
What do you think about the naming? I'm not sure...