Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnusedImports: False positive if referenced in @throws/@exception/@sample #2106

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

BraisGabin
Copy link
Member

UnusedImports: Fix false positive

When referenced in @throws, @exception or @sample in Kdoc block tag.

Fix #2098

When referenced in @throws, @exception or @sample in Kdoc block tag
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #2106 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2106   +/-   ##
=========================================
  Coverage     80.95%   80.95%           
  Complexity     2020     2020           
=========================================
  Files           336      336           
  Lines          5813     5813           
  Branches       1058     1058           
=========================================
  Hits           4706     4706           
  Misses          546      546           
  Partials        561      561
Impacted Files Coverage Δ Complexity Δ
...lab/arturbosch/detekt/rules/style/UnusedImports.kt 88.46% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bcb423...7542296. Read the comment docs.

@schalkms
Copy link
Member

Thanks for the quick fix!

@schalkms schalkms merged commit 75ec65b into detekt:master Nov 19, 2019
@BraisGabin BraisGabin deleted the unused-imports branch November 20, 2019 09:47
@arturbosch arturbosch added this to the 1.2.1 milestone Nov 27, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnusedImports: False positive if referenced only in @throws/@exception clause
4 participants