Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kotlin v1.3.60 #2109

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Update to Kotlin v1.3.60 #2109

merged 1 commit into from
Nov 21, 2019

Conversation

schalkms
Copy link
Member

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #2109 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2109      +/-   ##
============================================
- Coverage     80.95%   80.88%   -0.07%     
  Complexity     2020     2020              
============================================
  Files           336      336              
  Lines          5813     5813              
  Branches       1058     1064       +6     
============================================
- Hits           4706     4702       -4     
  Misses          546      546              
- Partials        561      565       +4
Impacted Files Coverage Δ Complexity Δ
.../arturbosch/detekt/cli/baseline/BaselineHandler.kt 72.22% <0%> (-11.12%) 12% <0%> (ø)
...n/kotlin/io/gitlab/arturbosch/detekt/rules/Junk.kt 50% <0%> (-10%) 0% <0%> (ø)
...lab/arturbosch/detekt/api/internal/PathMatchers.kt 54.54% <0%> (-9.1%) 0% <0%> (ø)
...detekt/rules/bugs/ExplicitGarbageCollectionCall.kt 66.66% <0%> (-8.34%) 7% <0%> (ø)
...b/arturbosch/detekt/api/internal/FailFastConfig.kt 36.36% <0%> (+9.09%) 5% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ec65b...c983058. Read the comment docs.

@schalkms
Copy link
Member Author

It's interesting that the code coverage went down.
There might be changes in the generated code by the newest Kotlin compiler.

@3flex 3flex merged commit d5e5e3b into detekt:master Nov 21, 2019
@arturbosch arturbosch added this to the 1.2.0 milestone Nov 23, 2019
@schalkms schalkms deleted the Kotlin-v1.3.60 branch November 26, 2019 22:28
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants