Return non-nullable string in DebtSumming class #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2113 +/- ##
=========================================
Coverage 80.48% 80.48%
Complexity 2018 2018
=========================================
Files 336 336
Lines 5802 5802
Branches 1064 1064
=========================================
Hits 4670 4670
Misses 564 564
Partials 568 568
Continue to review full report at Codecov.
|
|
TravisCI: Mac OS seems to have problems with JDK12. |
|
The build log tells us that Java 13 is used which is only supported by Gradle 6.0+ |
Since StringBuilder.toString() can't return null, both methods in the DebtSumming class also can't return null.
3flex
approved these changes
Nov 27, 2019
arturbosch
pushed a commit
that referenced
this pull request
Dec 5, 2019
Since StringBuilder.toString() can't return null, both methods in the DebtSumming class also can't return null.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
Since StringBuilder.toString() can't return null, both methods in the DebtSumming class also can't return null.
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
Since StringBuilder.toString() can't return null, both methods in the DebtSumming class also can't return null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since StringBuilder.toString() can't return null, both methods in the
DebtSumming class also can't return null.