Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE for EqualsAlwaysReturnsTrueOrFalse #2124

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Fix NPE for EqualsAlwaysReturnsTrueOrFalse #2124

merged 1 commit into from
Nov 26, 2019

Conversation

schalkms
Copy link
Member

Fixes an exception that occurs when the equals method contains no
dedicated return expression.
Closes #2103

Fixes an exception that occurs when the equals method contains no
dedicated return expression.
Closes #2103
@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #2124 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2124   +/-   ##
=========================================
  Coverage     80.62%   80.62%           
- Complexity     2015     2017    +2     
=========================================
  Files           336      336           
  Lines          5802     5802           
  Branches       1057     1058    +1     
=========================================
  Hits           4678     4678           
  Misses          563      563           
  Partials        561      561
Impacted Files Coverage Δ Complexity Δ
...etekt/rules/bugs/EqualsAlwaysReturnsTrueOrFalse.kt 84.21% <100%> (ø) 14 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b6f2e...5dd88d3. Read the comment docs.

@3flex 3flex merged commit 532cccd into detekt:master Nov 26, 2019
@arturbosch arturbosch added this to the 1.2.1 milestone Nov 26, 2019
@schalkms schalkms deleted the fix-#2103-EqualsAlwaysReturnsTrueOrFalse branch November 26, 2019 22:44
arturbosch pushed a commit that referenced this pull request Dec 5, 2019
Fixes an exception that occurs when the equals method contains no
dedicated return expression.
Closes #2103
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
Fixes an exception that occurs when the equals method contains no
dedicated return expression.
Closes detekt#2103
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
Fixes an exception that occurs when the equals method contains no
dedicated return expression.
Closes detekt#2103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EqualsAlwaysReturnsTrueOrFalse crashes on certain input
4 participants