Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.3.60 with fix for "Unable to load JNA library" warning #2129

Merged
merged 4 commits into from
Nov 26, 2019

Conversation

3flex
Copy link
Member

@3flex 3flex commented Nov 26, 2019

Update to 1.3.60 which also fixes #2118

As mentioned in JetBrains/kotlin@2568804 by enabling NIO2 in the Kotlin compiler environment it will not attempt to use JNA libraries, avoiding the warning raised in #2118.

This also changes what detekt does to call the function in the Kotlin compiler instead of applying fallback config function in the Kotlin compiler. It's assumed that function will be kept up to date with any necessary fixes/workarounds in future, and also would have avoided the JNA lib warning in the first place.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #2129 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2129      +/-   ##
============================================
- Coverage     80.55%   80.48%   -0.07%     
  Complexity     2016     2016              
============================================
  Files           336      336              
  Lines          5802     5802              
  Branches       1057     1063       +6     
============================================
- Hits           4674     4670       -4     
  Misses          564      564              
- Partials        564      568       +4
Impacted Files Coverage Δ Complexity Δ
...osch/detekt/api/internal/KotlinEnvironmentUtils.kt 86% <100%> (ø) 0 <0> (ø) ⬇️
.../arturbosch/detekt/cli/baseline/BaselineHandler.kt 72.22% <0%> (-11.12%) 12% <0%> (ø)
...n/kotlin/io/gitlab/arturbosch/detekt/rules/Junk.kt 50% <0%> (-10%) 0% <0%> (ø)
...lab/arturbosch/detekt/api/internal/PathMatchers.kt 54.54% <0%> (-9.1%) 0% <0%> (ø)
...detekt/rules/bugs/ExplicitGarbageCollectionCall.kt 66.66% <0%> (-8.34%) 7% <0%> (ø)
...b/arturbosch/detekt/api/internal/FailFastConfig.kt 36.36% <0%> (+9.09%) 5% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a59a9b...03a976c. Read the comment docs.

@3flex 3flex marked this pull request as ready for review November 26, 2019 02:08
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this!

@arturbosch arturbosch added this to the 1.2.1 milestone Nov 26, 2019
@arturbosch arturbosch merged commit 55560bb into master Nov 26, 2019
@arturbosch arturbosch deleted the 3flex/1.3.60-fix branch November 26, 2019 06:52
arturbosch pushed a commit that referenced this pull request Dec 5, 2019
* Update KotlinEnvironmentUtils.kt

* Kotlin 1.3.60

* Kotlin 1.3.60

* Update KotlinEnvironmentUtils.kt
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
…kt#2129)

* Update KotlinEnvironmentUtils.kt

* Kotlin 1.3.60

* Kotlin 1.3.60

* Update KotlinEnvironmentUtils.kt
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
…kt#2129)

* Update KotlinEnvironmentUtils.kt

* Kotlin 1.3.60

* Kotlin 1.3.60

* Update KotlinEnvironmentUtils.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to load JNA librar - kotlin 1.3.60
3 participants