Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test common config sections pass through config validation #2135

Merged
merged 1 commit into from Nov 29, 2019
Merged

Test common config sections pass through config validation #2135

merged 1 commit into from Nov 29, 2019

Conversation

arturbosch
Copy link
Member

Closes #2128

@arturbosch arturbosch added this to the 1.2.1 milestone Nov 27, 2019
@codecov-io
Copy link

codecov-io commented Nov 28, 2019 •
edited

Codecov Report

Merging #2135 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2135      +/-   ##
============================================
+ Coverage      80.5%   80.53%   +0.02%     
  Complexity     2015     2015              
============================================
  Files           336      336              
  Lines          5802     5809       +7     
  Branches       1064     1064              
============================================
+ Hits           4671     4678       +7     
  Misses          564      564              
  Partials        567      567
Impacted Files Coverage Δ Complexity Δ
...ch/detekt/api/internal/ValidatableConfiguration.kt 88.57% <100%> (+2.85%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8c7e7...72c1d8d. Read the comment docs.

schalkms
schalkms approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturbosch arturbosch merged commit 4390728 into master Nov 29, 2019
@arturbosch arturbosch deleted the build-weights branch November 29, 2019 09:00
arturbosch added a commit that referenced this pull request Dec 5, 2019
@arturbosch
Test common config sections pass through config validation - Closes #…
bc149a8 
…2128 (#2135)
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@arturbosch @smyachenkov
Test common config sections pass through config validation - Closes d…
db47a3a 
…etekt#2128 (detekt#2135)
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@arturbosch
Test common config sections pass through config validation - Closes d…
3408063 
…etekt#2128 (detekt#2135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Unexpected nested config for 'build>weights'.
3 participants
@arturbosch @codecov-io @schalkms