-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to create a common baseline file for multi module gradle projects #2140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 81.2% 80.5% -0.7%
+ Complexity 2064 2015 -49
==========================================
Files 340 336 -4
Lines 5910 5802 -108
Branches 1076 1064 -12
==========================================
- Hits 4799 4671 -128
- Misses 535 564 +29
+ Partials 576 567 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks!
docs/pages/baseline.md
Outdated
task projectBaseline(type: io.gitlab.arturbosch.detekt.DetektCreateBaselineTask) { | ||
description = "Overrides current baseline." | ||
|
||
input = files(rootProject.projectDir) | ||
config = files("$rootDir/detekt/config.yml") | ||
baseline = file(new File(rootProject.projectDir, "/detekt/baseline.xml")) | ||
failFast = true | ||
parallel = true | ||
include '**/*.kt' | ||
include '**/*.kts' | ||
exclude '**/test/resources/**' | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the entire task to the subprojects
block? It did not work correctly for me without doing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work on top level like in our build file. Inside subprojects
every sub-project would get a baseline task hm :/
… projects - Closes #2100
b627317
to
6cf1085
Compare
@adrianczuczka thanks for the suggestions, I've incorporated them and added a |
Closes #2100