Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to exclude detekt from the check task - #1894 #2144

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

arturbosch
Copy link
Member

The groovy dsl page has more info sub sections and the kotlin dsl page points to the groovy dsl page.
So it's okay not to duplicate the info ^^

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #2144 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2144      +/-   ##
============================================
+ Coverage      80.5%   80.52%   +0.02%     
  Complexity     2017     2017              
============================================
  Files           336      336              
  Lines          5801     5808       +7     
  Branches       1063     1063              
============================================
+ Hits           4670     4677       +7     
  Misses          564      564              
  Partials        567      567
Impacted Files Coverage Δ Complexity Δ
...ch/detekt/api/internal/ValidatableConfiguration.kt 88.57% <0%> (+2.85%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6848af...41fc0ba. Read the comment docs.

@@ -147,6 +147,24 @@ task detektFailFast(type: io.gitlab.arturbosch.detekt.Detekt) {
}
```

##### <a name="check-lifecycle">Disabling detekt from the check task</a>

detekt tasks by default are verification tasks. They get executed whenever the Gradle check task gets executed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
detekt tasks by default are verification tasks. They get executed whenever the Gradle check task gets executed.
Detekt tasks by default are verification tasks. They get executed whenever the Gradle check task gets executed.

@arturbosch arturbosch added this to the 1.2.2 milestone Dec 3, 2019
@arturbosch arturbosch merged commit 3e673c8 into master Dec 3, 2019
@arturbosch arturbosch deleted the gradle-check branch December 3, 2019 15:51
arturbosch added a commit that referenced this pull request Dec 5, 2019
* Document how to exclude detekt from the check task - #1894

* Use capital letter for detekt
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
…ekt#2144)

* Document how to exclude detekt from the check task - detekt#1894

* Use capital letter for detekt
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
…ekt#2144)

* Document how to exclude detekt from the check task - detekt#1894

* Use capital letter for detekt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants