Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringIndexOutOfBoundsException when generating HTML report #2160

Merged
merged 1 commit into from Dec 5, 2019
Merged

StringIndexOutOfBoundsException when generating HTML report #2160

merged 1 commit into from Dec 5, 2019

Conversation

dafi
Copy link
Contributor

@dafi dafi commented Dec 3, 2019

This fixes the bug related to the issue #2134

@dafi dafi mentioned this pull request Dec 3, 2019
Closed
@codecov-io
Copy link

Codecov Report

Merging #2160 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2160      +/-   ##
============================================
- Coverage     80.52%   80.49%   -0.03%     
  Complexity     2017     2017              
============================================
  Files           336      336              
  Lines          5808     5810       +2     
  Branches       1063     1064       +1     
============================================
  Hits           4677     4677              
- Misses          564      565       +1     
- Partials        567      568       +1
Impacted Files Coverage Δ Complexity Δ
...n/io/gitlab/arturbosch/detekt/cli/out/HtmlUtils.kt 92.85% <33.33%> (-7.15%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af3fe2...84ee386. Read the comment docs.

schalkms
schalkms approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still want to merge this, since the HTML report shouldn't crash if a rule reports an invalid column for a code snippet.
Thanks for this awesome first contribution!! @dafi

@arturbosch arturbosch added this to the 1.2.2 milestone Dec 5, 2019
@arturbosch arturbosch merged commit b758476 into detekt:master Dec 5, 2019
arturbosch pushed a commit that referenced this pull request Dec 5, 2019
@dafi @arturbosch
Fix StringIndexOutOfBoundsException when generating HTML report (#2160)
cadd892
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@dafi @smyachenkov
Fix StringIndexOutOfBoundsException when generating HTML report (dete…
309ba2f 
…kt#2160)
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@dafi
Fix StringIndexOutOfBoundsException when generating HTML report (dete…
0148b29 
…kt#2160)
BraisGabin added a commit to BraisGabin/detekt that referenced this pull request Dec 28, 2019
@BraisGabin
Revert "Fix StringIndexOutOfBoundsException when generating HTML repo…
cc9769b 
…rt (detekt#2160)"

This reverts commit b758476.
arturbosch pushed a commit that referenced this pull request Dec 28, 2019
@BraisGabin @arturbosch
Show code snippet erros in html reports (#2209)
5f3b47e 
* Revert "Fix StringIndexOutOfBoundsException when generating HTML report (#2160)"

This reverts commit b758476.

* whichDetekt can return null

* Show a message when we find an error diplaying the code snippet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dafi @codecov-io @schalkms @arturbosch