Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeCast: update documentation to match new behavior #2164

Merged
merged 2 commits into from
Dec 10, 2019
Merged

UnsafeCast: update documentation to match new behavior #2164

merged 2 commits into from
Dec 10, 2019

Conversation

xouabita
Copy link
Contributor

@xouabita xouabita commented Dec 4, 2019

Update the documentation to match the behavior of this rule after #1879.
The rule now report impossible casts.

See #2153

@codecov-io
Copy link

codecov-io commented Dec 7, 2019

Codecov Report

Merging #2164 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2164      +/-   ##
============================================
+ Coverage     80.52%   80.58%   +0.05%     
- Complexity     2017     2024       +7     
============================================
  Files           336      337       +1     
  Lines          5808     5836      +28     
  Branches       1063     1065       +2     
============================================
+ Hits           4677     4703      +26     
  Misses          564      564              
- Partials        567      569       +2
Impacted Files Coverage Δ Complexity Δ
.../gitlab/arturbosch/detekt/rules/bugs/UnsafeCast.kt 75% <ø> (ø) 4 <0> (ø) ⬇️
...n/io/gitlab/arturbosch/detekt/cli/out/HtmlUtils.kt 92.85% <0%> (-7.15%) 0% <0%> (ø)
...bosch/detekt/rules/providers/StyleGuideProvider.kt 100% <0%> (ø) 3% <0%> (ø) ⬇️
.../rules/style/UnnecessaryAnnotationUseSiteTarget.kt 96% <0%> (ø) 7% <0%> (?)
...kotlin/io/gitlab/arturbosch/detekt/api/Location.kt 81.48% <0%> (+3.7%) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4373748...0b4e183. Read the comment docs.

@xouabita xouabita marked this pull request as ready for review December 7, 2019 18:13
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks!!

@schalkms schalkms merged commit 8f56648 into detekt:master Dec 10, 2019
@arturbosch arturbosch added this to the 1.3.0 milestone Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants