Fix Detekt gradle task cache restoration issue (#2180) #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
=========================================
Coverage 80.59% 80.59%
Complexity 2028 2028
=========================================
Files 338 338
Lines 5850 5850
Branches 1066 1066
=========================================
Hits 4715 4715
Misses 564 564
Partials 571 571Continue to review full report at Codecov.
|
schalkms
approved these changes
Dec 16, 2019
plastiv
force-pushed
the
sp_fix_cache_relocation
branch
from
f055642
to
62b9540
Compare
`Detekt` gradle task is marked as `@CacheableTask` but it's input source files are marked with `PathSensitivity.ABSOLUTE` annotation from `source` property defined in parent `SourceTask`. Having task inputs with absolute path sensitivity effectively disables cache reusability: https://guides.gradle.org/using-build-cache/#relocatability
plastiv
force-pushed
the
sp_fix_cache_relocation
branch
from
62b9540
to
447ca33
Compare
|
Thanks for picking that up, plus the fix! |
|
@3flex is there a way to get a snapshot for gradle-plugin? I don't see it being published here https://oss.jfrog.org/artifactory/webapp/#/artifacts/browse/tree/General/oss-snapshot-local/io/gitlab/arturbosch/detekt |
|
Not sure, I don't have access to publish artifacts. @arturbosch do you know if anything can be done here? @plastiv consider opening a new issue to track this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detektgradle task is marked as@CacheableTaskbut it's input source files aremarked with
PathSensitivity.ABSOLUTEannotation fromsourceproperty defined inparent
SourceTask.Having task inputs with absolute path sensitivity effectively disables cache reusability:
https://guides.gradle.org/using-build-cache/#relocatability
Closes #2180