-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add printers to the command line runner #2188
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2188 +/- ##
============================================
+ Coverage 80.75% 81.12% +0.36%
- Complexity 2032 2055 +23
============================================
Files 338 339 +1
Lines 5841 5874 +33
Branches 1066 1070 +4
============================================
+ Hits 4717 4765 +48
+ Misses 554 536 -18
- Partials 570 573 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me, since this PR is backwards compatible.
@arturdryomov the bazel detekt plugin is cool. Thanks for doing this! +1 star |
@schalkms, sure — expanded the test suite a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🥇
A bit of context to understand the motivation behind the change.
Me and @artem-zinnatullin are working on the Bazel rule for Detekt. One of the features of the rule is the persistent workers support.
If this change is accepted (and eventually published) we’ll be able to make Detekt invocations more or less hermetic. At the same time, the API change is backwards-compatible (arguments fall back to default values) and kinda makes sense abstracting from our personal needs (there is no way to change printers since
ProcessingSettings
inRunner
are not accessible).