Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests showing how to exclude custom config properties in plugins #2192

Merged
merged 2 commits into from
Dec 26, 2019

Conversation

arturbosch
Copy link
Member

Closes #2169

@codecov-io
Copy link

codecov-io commented Dec 26, 2019

Codecov Report

Merging #2192 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2192      +/-   ##
============================================
+ Coverage     81.12%   81.15%   +0.03%     
- Complexity     2055     2057       +2     
============================================
  Files           339      339              
  Lines          5874     5891      +17     
  Branches       1070     1073       +3     
============================================
+ Hits           4765     4781      +16     
+ Misses          536      535       -1     
- Partials        573      575       +2
Impacted Files Coverage Δ Complexity Δ
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100% <100%> (ø) 6 <0> (ø) ⬇️
...in/io/gitlab/arturbosch/detekt/cli/BuildFailure.kt 90.62% <0%> (-4.83%) 1% <0%> (ø)
...n/io/gitlab/arturbosch/detekt/core/DetektFacade.kt 48.78% <0%> (ø) 3% <0%> (ø) ⬇️
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 75% <0%> (ø) 8% <0%> (ø) ⬇️
...osch/detekt/cli/console/FileBasedFindingsReport.kt 92.59% <0%> (+0.92%) 8% <0%> (+1%) ⬆️
...ab/arturbosch/detekt/cli/console/FindingsReport.kt 94.11% <0%> (+1.26%) 7% <0%> (+1%) ⬆️
...otlin/io/gitlab/arturbosch/detekt/api/CodeSmell.kt 60.46% <0%> (+2.32%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a754335...7c07766. Read the comment docs.

@arturbosch arturbosch added this to the 1.3.1 milestone Dec 26, 2019
@arturbosch arturbosch merged commit 10f97d2 into master Dec 26, 2019
@arturbosch arturbosch deleted the sample-config-tests branch December 26, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom rules are not applied on Android
3 participants