Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid config exit code in gradle plugin #2193

Merged
merged 2 commits into from
Dec 26, 2019
Merged

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Dec 26, 2019

Closes #2168

@arturbosch arturbosch added this to the 1.3.1 milestone Dec 26, 2019
@codecov-io
Copy link

codecov-io commented Dec 26, 2019

Codecov Report

Merging #2193 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2193      +/-   ##
============================================
+ Coverage     81.12%   81.15%   +0.03%     
- Complexity     2055     2057       +2     
============================================
  Files           339      339              
  Lines          5874     5890      +16     
  Branches       1070     1073       +3     
============================================
+ Hits           4765     4780      +15     
+ Misses          536      535       -1     
- Partials        573      575       +2
Impacted Files Coverage Δ Complexity Δ
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 88.88% <ø> (ø) 10 <0> (ø) ⬇️
...in/io/gitlab/arturbosch/detekt/cli/BuildFailure.kt 90.62% <0%> (-4.83%) 1% <0%> (ø)
...n/io/gitlab/arturbosch/detekt/core/DetektFacade.kt 48.78% <0%> (ø) 3% <0%> (ø) ⬇️
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 75% <0%> (ø) 8% <0%> (ø) ⬇️
...osch/detekt/cli/console/FileBasedFindingsReport.kt 92.59% <0%> (+0.92%) 8% <0%> (+1%) ⬆️
...ab/arturbosch/detekt/cli/console/FindingsReport.kt 94.11% <0%> (+1.26%) 7% <0%> (+1%) ⬆️
...otlin/io/gitlab/arturbosch/detekt/api/CodeSmell.kt 60.46% <0%> (+2.32%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a754335...75502e4. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Can you also please update the docs on the website?
https://arturbosch.github.io/detekt/cli.html

@arturbosch
Copy link
Member Author

Good catch, updated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exit with error if unsupported property is detected
3 participants