Attach FILE_PATH_USER_DATA_KEY user data on FormattingRules (#1907) #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rules such as `Filename` and other that require the FILE_PATH_USER_DATA_KEY user data attached to the ASTNode in order to properly work. Fixes detekt#1907
Codecov Report
@@ Coverage Diff @@
## master #2194 +/- ##
============================================
+ Coverage 81.17% 81.17% +<.01%
Complexity 2059 2059
============================================
Files 339 339
Lines 5891 5892 +1
Branches 1073 1073
============================================
+ Hits 4782 4783 +1
Misses 535 535
Partials 574 574
Continue to review full report at Codecov.
|
schalkms
approved these changes
Dec 27, 2019
arturbosch
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rules such as
Filenameand other that requirethe FILE_PATH_USER_DATA_KEY user data attached to the ASTNode
in order to properly work.
More context on this fix is on #1907
Fixes #1907