Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type resolution doc #2198

Merged
merged 4 commits into from
Dec 27, 2019
Merged

Type resolution doc #2198

merged 4 commits into from
Dec 27, 2019

Conversation

schalkms
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #2198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2198   +/-   ##
=========================================
  Coverage     81.17%   81.17%           
  Complexity     2059     2059           
=========================================
  Files           339      339           
  Lines          5891     5891           
  Branches       1073     1072    -1     
=========================================
  Hits           4782     4782           
  Misses          535      535           
  Partials        574      574
Impacted Files Coverage Δ Complexity Δ
...itlab/arturbosch/detekt/rules/style/MagicNumber.kt 89.47% <0%> (-0.14%) 60% <0%> (ø)
...lab/arturbosch/detekt/formatting/FormattingRule.kt 74.07% <0%> (+0.99%) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa21086...b763078. Read the comment docs.

@@ -112,6 +112,15 @@ detekt {
}
```

##### Using Type Resolution

```kotlin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groovy I guess :)

Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an introductory sentence that type resolution is experimental and works only for predefined detektMain and detektTest tasks or when implementing a custom detekt task with both classpath and jvmTarget proeprties present.

@arturbosch arturbosch added this to the 1.3.1 milestone Dec 27, 2019
@arturbosch arturbosch merged commit edd1a6a into detekt:master Dec 27, 2019
@schalkms schalkms deleted the type-resolution-doc branch December 30, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants