Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin: Build upon default detekt config #2227

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

3flex
Copy link
Member

@3flex 3flex commented Jan 7, 2020

Fixes #2217

When a new rule is added before it's available in the version of detekt that the Gradle plugin uses, the config validation fails because the default detekt config file includes a config for the new rule that the Gradle plugin's detekt version doesn't yet know about.

@codecov-io
Copy link

Codecov Report

Merging #2227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2227   +/-   ##
=========================================
  Coverage     81.41%   81.41%           
  Complexity     2064     2064           
=========================================
  Files           340      340           
  Lines          5934     5934           
  Branches       1077     1077           
=========================================
  Hits           4831     4831           
  Misses          526      526           
  Partials        577      577

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3a0ea...13d7e42. Read the comment docs.

@schalkms schalkms merged commit f5d251c into detekt:master Jan 7, 2020
@3flex 3flex deleted the 2217-fix branch January 7, 2020 11:37
@arturbosch arturbosch added this to the 1.4.0 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Property is misspelled or does not exist" error for new rules in default rulesets
4 participants