Skip to content

New ktlint rules #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2020
Merged

New ktlint rules #2243

merged 2 commits into from
Jan 11, 2020

Conversation

3flex
Copy link
Member

@3flex 3flex commented Jan 11, 2020

  • EnumEntryNameCase
  • NoEmptyFirstLineInMethodBlock

Both are from the ktlint experimental rule set so not enabled by default.

@3flex 3flex added the blocked label Jan 11, 2020
@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #2243 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2243      +/-   ##
============================================
+ Coverage     81.38%   81.42%   +0.04%     
- Complexity     2074     2081       +7     
============================================
  Files           343      345       +2     
  Lines          5984     5993       +9     
  Branches       1086     1086              
============================================
+ Hits           4870     4880      +10     
  Misses          532      532              
+ Partials        582      581       -1
Impacted Files Coverage Δ Complexity Δ
...rmatting/wrappers/NoEmptyFirstLineInMethodBlock.kt 100% <100%> (ø) 2 <2> (?)
...ch/detekt/formatting/wrappers/EnumEntryNameCase.kt 100% <100%> (ø) 2 <2> (?)
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt 87.75% <100%> (+0.52%) 6 <0> (ø) ⬇️
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 93.47% <0%> (ø) 5% <0%> (ø) ⬇️
...osch/detekt/rules/bugs/WrongEqualsTypeParameter.kt 100% <0%> (ø) 10% <0%> (+3%) ⬆️
.../gitlab/arturbosch/detekt/rules/MethodSignature.kt 70% <0%> (+10%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfe7c5...f22d5e7. Read the comment docs.

@3flex 3flex removed the blocked label Jan 11, 2020
@schalkms schalkms merged commit 79d77fe into detekt:master Jan 11, 2020
@3flex 3flex deleted the new-ktlint-rules branch January 11, 2020 22:51
@arturbosch arturbosch added this to the 1.4.0 milestone Jan 12, 2020
@3flex 3flex restored the new-ktlint-rules branch July 29, 2021 12:11
@3flex 3flex deleted the new-ktlint-rules branch November 19, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants