Skip to content

Add RedundantSuspendModifier rule #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Add RedundantSuspendModifier rule #2244

merged 1 commit into from
Jan 12, 2020

Conversation

3flex
Copy link
Member

@3flex 3flex commented Jan 11, 2020

Closes #2156

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #2244 into master will decrease coverage by 0.09%.
The diff coverage is 63.04%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2244     +/-   ##
===========================================
- Coverage     81.38%   81.28%   -0.1%     
- Complexity     2074     2101     +27     
===========================================
  Files           343      346      +3     
  Lines          5984     6038     +54     
  Branches       1086     1106     +20     
===========================================
+ Hits           4870     4908     +38     
- Misses          532      533      +1     
- Partials        582      597     +15
Impacted Files Coverage Δ Complexity Δ
...sch/detekt/rules/providers/PotentialBugProvider.kt 100% <ø> (ø) 3 <0> (ø) ⬇️
...bosch/detekt/rules/providers/CoroutinesProvider.kt 100% <100%> (ø) 3 <0> (ø) ⬇️
...etekt/rules/coroutines/RedundantSuspendModifier.kt 61.36% <61.36%> (ø) 20 <20> (?)
...turbosch/detekt/rules/style/UnusedPrivateMember.kt 93.47% <0%> (ø) 5% <0%> (ø) ⬇️
...osch/detekt/rules/bugs/WrongEqualsTypeParameter.kt 100% <0%> (ø) 10% <0%> (+3%) ⬆️
...rmatting/wrappers/NoEmptyFirstLineInMethodBlock.kt 100% <0%> (ø) 2% <0%> (?)
...ch/detekt/formatting/wrappers/EnumEntryNameCase.kt 100% <0%> (ø) 2% <0%> (?)
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt 87.75% <0%> (+0.52%) 6% <0%> (ø) ⬇️
.../gitlab/arturbosch/detekt/rules/MethodSignature.kt 70% <0%> (+10%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfe7c5...b208d07. Read the comment docs.

@arturbosch arturbosch added this to the 1.4.0 milestone Jan 12, 2020
@arturbosch arturbosch merged commit ac6d243 into detekt:master Jan 12, 2020
@3flex 3flex deleted the 2156-fix branch January 12, 2020 21:00
@3flex 3flex restored the 2156-fix branch July 29, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rule [RedundantSuspend] to detect redundant suspend modifiers
3 participants