Reduce complexity in FindingsReport #2246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following tests were added: * case where 2 rule sets contain at least 1 code smell * excludeCorrectable=true -> issues are not included in the report
This allows to separate business logic from the printing view.
* Removes duplicated test: rule set contains no smells * Don't create unnecessary irrelevant findings for a test case
schalkms
commented
Jan 11, 2020
| * Rules can classified into different severity grades. Maintainer can choose | ||
| * a grade which is most harmful to their projects. | ||
| */ | ||
| enum class Severity { |
There was a problem hiding this comment.
Moved this enum class into a separate .kt file.
| * Debt describes the estimated amount of work needed to fix a given issue. | ||
| */ | ||
| @Suppress("MagicNumber") | ||
| data class Debt(val days: Int = 0, val hours: Int = 0, val mins: Int = 0) { |
There was a problem hiding this comment.
Moved this data class into a separate .kt file.
Codecov Report
@@ Coverage Diff @@
## master #2246 +/- ##
===========================================
- Coverage 81.42% 81.4% -0.03%
- Complexity 2081 2085 +4
===========================================
Files 345 346 +1
Lines 5993 5975 -18
Branches 1086 1082 -4
===========================================
- Hits 4880 4864 -16
- Misses 532 533 +1
+ Partials 581 578 -3
Continue to review full report at Codecov.
|
arturbosch
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the complexity in both
FindingsReportclasses and adds some tests to the corresponding Spek classes.There's still some code duplication there, which I'll tackle in a subsequent PR.