Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify argument parsing logic, remove any exitProcess() calls from buildRunner #2260

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch changed the title Simplify argument parsing logic Simplify argument parsing logic, removing any exitProcess() calls from buildRunner Jan 15, 2020
@arturbosch arturbosch changed the title Simplify argument parsing logic, removing any exitProcess() calls from buildRunner Simplify argument parsing logic, remove any exitProcess() calls from buildRunner Jan 15, 2020
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #2260 into master will increase coverage by 0.09%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2260      +/-   ##
===========================================
+ Coverage     81.61%   81.7%   +0.09%     
+ Complexity     2120    2118       -2     
===========================================
  Files           349     349              
  Lines          6054    6047       -7     
  Branches       1106    1108       +2     
===========================================
  Hits           4941    4941              
+ Misses          524     517       -7     
  Partials        589     589
Impacted Files Coverage Δ Complexity Δ
...tlin/io/gitlab/arturbosch/detekt/generator/Main.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../kotlin/io/gitlab/arturbosch/detekt/cli/CliArgs.kt 100% <100%> (ø) 6 <0> (ø) ⬇️
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt 36% <33.33%> (-14%) 6 <5> (-1)
...tlin/io/gitlab/arturbosch/detekt/cli/JCommander.kt 62.5% <62.5%> (+62.5%) 0 <0> (ø) ⬇️
...n/kotlin/io/gitlab/arturbosch/detekt/cli/Errors.kt 66.66% <66.66%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81494bf...5a68b40. Read the comment docs.

@arturbosch arturbosch added this to the 1.5.0 milestone Jan 19, 2020
Only the main method is responsible in calling exitSystem(int). This allows other tools easier to embed detekt.
@arturbosch arturbosch merged commit c58b535 into master Jan 19, 2020
@arturbosch arturbosch deleted the simplify-arg-parsing branch January 19, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants