Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize gradle build scripts and suppress unstable api usages #2271

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.5.0 milestone Jan 19, 2020
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure, whether we should suppress these issues.
Why did you remove the BuildFailure exception?

@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #2271 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2271      +/-   ##
============================================
+ Coverage     81.61%   81.65%   +0.03%     
+ Complexity     2120     2110      -10     
============================================
  Files           349      348       -1     
  Lines          6054     6033      -21     
  Branches       1106     1105       -1     
============================================
- Hits           4941     4926      -15     
+ Misses          524      518       -6     
  Partials        589      589
Impacted Files Coverage Δ Complexity Δ
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt 36% <0%> (-14%) 6% <0%> (-1%)
.../io/gitlab/arturbosch/detekt/cli/IssueExtension.kt 87.09% <0%> (-6.46%) 0% <0%> (ø)
...in/io/gitlab/arturbosch/detekt/cli/OutputFacade.kt 94.11% <0%> (-0.62%) 6% <0%> (-3%)
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 87.71% <0%> (ø) 15% <0%> (ø) ⬇️
...tlin/io/gitlab/arturbosch/detekt/generator/Main.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ekt/generator/printer/rulesetpage/ConfigPrinter.kt 76.74% <0%> (ø) 8% <0%> (ø) ⬇️
...rturbosch/detekt/cli/console/BuildFailureReport.kt
...in/io/gitlab/arturbosch/detekt/cli/BuildFailure.kt
...n/kotlin/io/gitlab/arturbosch/detekt/cli/Errors.kt 66.66% <0%> (ø) 0% <0%> (?)
...lab/arturbosch/detekt/core/FileProcessorLocator.kt 84.61% <0%> (+7.69%) 4% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81494bf...6233e39. Read the comment docs.

@arturbosch
Copy link
Member Author

I’m not sure, whether we should suppress these issues.

Yeah maybe not, this way we will see when the api gets stable. I revert them.

Why did you remove the BuildFailure exception?

It was only used in the ProcessExecutor which is again only used by the Idea wrapper tasks. Gradle will treat it as a build failure for us. I think it is legacy code from before the gradle rewrite to dynamic resolution.

@arturbosch arturbosch merged commit e827575 into master Jan 19, 2020
@arturbosch arturbosch deleted the sanitize-gradle branch January 19, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants