Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class loader memory leaks when loading services #2277

Merged
merged 3 commits into from
Jan 19, 2020

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.5.0 milestone Jan 19, 2020
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #2277 into master will increase coverage by 0.04%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2277      +/-   ##
============================================
+ Coverage     81.65%   81.69%   +0.04%     
- Complexity     2109     2112       +3     
============================================
  Files           348      348              
  Lines          6033     6031       -2     
  Branches       1105     1104       -1     
============================================
+ Hits           4926     4927       +1     
  Misses          518      518              
+ Partials        589      586       -3
Impacted Files Coverage Δ Complexity Δ
...n/io/gitlab/arturbosch/detekt/cli/ReportLocator.kt 79.16% <100%> (-0.84%) 6 <0> (ø)
...itlab/arturbosch/detekt/core/ProcessingSettings.kt 90.47% <100%> (+0.47%) 18 <2> (ø) ⬇️
...io/gitlab/arturbosch/detekt/core/RuleSetLocator.kt 100% <100%> (ø) 7 <3> (ø) ⬇️
...lab/arturbosch/detekt/core/FileProcessorLocator.kt 81.81% <66.66%> (-2.8%) 4 <4> (ø)
...otlin/io/gitlab/arturbosch/detekt/core/TaskPool.kt 66.66% <0%> (+33.33%) 6% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e827575...2b33730. Read the comment docs.

arturbosch and others added 2 commits January 19, 2020 19:34
…uleSetLocatorTest.kt

Co-Authored-By: M Schalk <30376729+schalkms@users.noreply.github.com>
@arturbosch arturbosch merged commit 618207b into master Jan 19, 2020
@arturbosch arturbosch deleted the fix-memory-leak-on-errors branch January 19, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants