Introduce DefaultRuleSetProvider interface marking detekt-rules providers as default#2279
Merged
Conversation
…ders as default This way we won't forget to add new Provider's like we did with `CoroutinesProvider`.
schalkms
approved these changes
Jan 19, 2020
Member
schalkms
left a comment
schalkms
left a comment
There was a problem hiding this comment.
Could you please check if the RuleSetProvider is referenced in a config validation test or in the generator module via string?
Codecov Report
@@ Coverage Diff @@
## master #2279 +/- ##
============================================
- Coverage 81.69% 81.68% -0.02%
+ Complexity 2112 2111 -1
============================================
Files 348 348
Lines 6031 6032 +1
Branches 1104 1105 +1
============================================
Hits 4927 4927
- Misses 518 519 +1
Partials 586 586
Continue to review full report at Codecov.
|
Member
Author
|
Looks good, I had to add the new interface to the generator. No |
cortinico
pushed a commit
to cortinico/detekt
that referenced
this pull request
Jan 20, 2020
…ders as default (detekt#2279) This way we won't forget to add new Provider's like we did with `CoroutinesProvider`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we won't forget to add new Provider's like we did with
CoroutinesProvider.