Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort html report #2290

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Sort html report #2290

merged 2 commits into from
Jan 27, 2020

Conversation

BraisGabin
Copy link
Member

Fixes #2287

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #2290 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2290   +/-   ##
=========================================
  Coverage     81.71%   81.71%           
  Complexity     2111     2111           
=========================================
  Files           348      348           
  Lines          6044     6044           
  Branches       1105     1105           
=========================================
  Hits           4939     4939           
  Misses          519      519           
  Partials        586      586
Impacted Files Coverage Δ Complexity Δ
...tlab/arturbosch/detekt/cli/out/HtmlOutputReport.kt 92.64% <100%> (-1.01%) 17 <0> (+1)
.../arturbosch/detekt/cli/console/ComplexityReport.kt 100% <0%> (ø) 3% <0%> (-1%) ⬇️
...ch/detekt/cli/console/ComplexityReportGenerator.kt 88% <0%> (+1.04%) 5% <0%> (ø) ⬇️
.../kotlin/io/gitlab/arturbosch/detekt/api/Context.kt 50% <0%> (+6.25%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605506d...8287280. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will get some merge conflicts with #2288, I guess.
Is there something in this PR which is duplicated with #2288? One the first glance it seems to me that there is actually copied code in here.

@BraisGabin
Copy link
Member Author

The first commit is exactly the same. Because I needed that refactor in the tests too for this. I will rebase this or #2288 as soon as the other is merged. We can block this one if you want.

@schalkms
Copy link
Member

Rebasing is the best option, I think.

@arturbosch arturbosch added this to the 1.5.0 milestone Jan 27, 2020
@BraisGabin
Copy link
Member Author

Rebased. We can unblock it.

@arturbosch arturbosch merged commit efd6da7 into detekt:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep the order of the issues in the html report
4 participants