Fix ExplicitCollectionElementAccessMethod crash #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule shouldn't crash for getter and setter that have no parent expression. Fixes #2301
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
===========================================
+ Coverage 81.73% 81.8% +0.06%
- Complexity 2111 2117 +6
===========================================
Files 348 348
Lines 6050 6050
Branches 1105 1106 +1
===========================================
+ Hits 4945 4949 +4
+ Misses 519 518 -1
+ Partials 586 583 -3
Continue to review full report at Codecov.
|
BraisGabin
reviewed
Jan 29, 2020
.../kotlin/io/gitlab/arturbosch/detekt/rules/style/ExplicitCollectionElementAccessMethodSpec.kt
Outdated
Show resolved
Hide resolved
arturbosch
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule shouldn't crash for getter and setter that have no parent expression.
Fixes #2301