Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExplicitCollectionElementAccessMethod crash #2302

Merged
merged 3 commits into from
Feb 3, 2020
Merged

Fix ExplicitCollectionElementAccessMethod crash #2302

merged 3 commits into from
Feb 3, 2020

Conversation

schalkms
Copy link
Member

The rule shouldn't crash for getter and setter that have no parent expression.
Fixes #2301

The rule shouldn't crash for getter and setter that have no parent expression.
Fixes #2301
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #2302 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2302      +/-   ##
===========================================
+ Coverage     81.73%   81.8%   +0.06%     
- Complexity     2111    2117       +6     
===========================================
  Files           348     348              
  Lines          6050    6050              
  Branches       1105    1106       +1     
===========================================
+ Hits           4945    4949       +4     
+ Misses          519     518       -1     
+ Partials        586     583       -3
Impacted Files Coverage Δ Complexity Δ
...les/style/ExplicitCollectionElementAccessMethod.kt 90.62% <100%> (+12.5%) 16 <3> (+6) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22216d3...5b378d7. Read the comment docs.

@arturbosch arturbosch merged commit 8710f99 into detekt:master Feb 3, 2020
@arturbosch arturbosch added this to the 1.5.1 milestone Feb 3, 2020
@schalkms schalkms deleted the fix-#2301_ExplicitCollectionElementAccessMethod branch February 6, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExplicitCollectionElementAccessMethod crashes
4 participants