Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: MagicNumber with ignoreNamedArgument and a negative value #2315

Merged

Conversation

jonasfa
Copy link
Contributor

@jonasfa jonasfa commented Feb 4, 2020

Fixes #530

@schalkms
Copy link
Member

schalkms commented Feb 4, 2020

Thanks for this bug fix as a your first contribution!

@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #2315 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2315      +/-   ##
============================================
- Coverage      81.8%   81.79%   -0.01%     
- Complexity     2117     2118       +1     
============================================
  Files           348      348              
  Lines          6050     6053       +3     
  Branches       1106     1108       +2     
============================================
+ Hits           4949     4951       +2     
  Misses          518      518              
- Partials        583      584       +1
Impacted Files Coverage Δ Complexity Δ
...itlab/arturbosch/detekt/rules/style/MagicNumber.kt 88.6% <50%> (-0.87%) 61 <3> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d59a2...2a0190a. Read the comment docs.

@jonasfa jonasfa force-pushed the bugfix_false_negative_magic_number_negative branch from 5dfe4bd to 2a0190a Compare February 6, 2020 09:35
@jonasfa
Copy link
Contributor Author

jonasfa commented Feb 6, 2020

Rebased

@schalkms schalkms merged commit 8c0c994 into detekt:master Feb 6, 2020
@arturbosch arturbosch added this to the 1.6.0 milestone Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False-positive MagicNumber issue reported when using negative numbers
4 participants