Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add details into internal validation #2347

Merged
merged 9 commits into from
Feb 23, 2020

Conversation

imanushin
Copy link
Contributor

Initial purpose to change - add details into YamlConfig validation.

And in addition, more details were added into the project internal error raise.

Please check DetektGenerateConfigTask, because semantic was changed: from now actual error is provided to gradle. It means, that --stacktrace gradle option is able to show detekt's stack.

@imanushin imanushin requested review from schalkms and removed request for schalkms February 15, 2020 18:59
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please rebase on current master and try to break on ?: to get rid of the MaxLineLength issues :).

@arturbosch arturbosch added this to the 1.6.0 milestone Feb 19, 2020
@imanushin
Copy link
Contributor Author

Thanks!

I'll fix this at the next weekend. A little busy we weekdays, sorry.

BraisGabin
BraisGabin previously approved these changes Feb 22, 2020
@codecov-io
Copy link

codecov-io commented Feb 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2f68430). Click here to learn what that means.
The diff coverage is 79.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2347   +/-   ##
=========================================
  Coverage          ?   82.82%           
  Complexity        ?     2160           
=========================================
  Files             ?      352           
  Lines             ?     6077           
  Branches          ?     1112           
=========================================
  Hits              ?     5033           
  Misses            ?      472           
  Partials          ?      572
Impacted Files Coverage Δ Complexity Δ
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt 36% <ø> (ø) 6 <0> (?)
...etekt/formatting/wrappers/ParameterListWrapping.kt 100% <ø> (ø) 4 <0> (?)
...ch/detekt/formatting/wrappers/MaximumLineLength.kt 88.88% <ø> (ø) 5 <0> (?)
...tlab/arturbosch/detekt/cli/config/InvalidConfig.kt 100% <ø> (ø) 1 <0> (?)
...turbosch/detekt/formatting/wrappers/Indentation.kt 100% <ø> (ø) 4 <0> (?)
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 92.3% <ø> (ø) 12 <0> (?)
...itlab/arturbosch/detekt/api/internal/Validation.kt 33.33% <0%> (ø) 0 <0> (?)
...b/arturbosch/detekt/api/internal/FailFastConfig.kt 36.36% <0%> (ø) 5 <0> (?)
...osch/detekt/api/internal/KotlinEnvironmentUtils.kt 84.9% <0%> (ø) 0 <0> (?)
...ch/detekt/api/internal/ValidatableConfiguration.kt 100% <100%> (ø) 0 <0> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f68430...e40dd8c. Read the comment docs.

@imanushin
Copy link
Contributor Author

@BraisGabin, fixed. Apologise for that.

@arturbosch arturbosch merged commit 059017c into detekt:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants