-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add details into internal validation #2347
add details into internal validation #2347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR!
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/Validation.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please rebase on current master and try to break on ?:
to get rid of the MaxLineLength
issues :).
Thanks! I'll fix this at the next weekend. A little busy we weekdays, sorry. |
detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/KtCompilerTest.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2347 +/- ##
=========================================
Coverage ? 82.82%
Complexity ? 2160
=========================================
Files ? 352
Lines ? 6077
Branches ? 1112
=========================================
Hits ? 5033
Misses ? 472
Partials ? 572
Continue to review full report at Codecov.
|
@BraisGabin, fixed. Apologise for that. |
Initial purpose to change - add details into YamlConfig validation.
And in addition, more details were added into the project internal error raise.
Please check DetektGenerateConfigTask, because semantic was changed: from now actual error is provided to gradle. It means, that
--stacktrace
gradle option is able to showdetekt
's stack.