Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for setting KtLint's config #2348

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Add tests for setting KtLint's config #2348

merged 2 commits into from
Feb 18, 2020

Conversation

schalkms
Copy link
Member

The tests assert that the config options for KtLints rules are set correctly via detekt.

The tests assert that the config options for KtLints rules are set correctly via detekt.
@codecov-io
Copy link

codecov-io commented Feb 16, 2020

Codecov Report

Merging #2348 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2348      +/-   ##
============================================
+ Coverage     82.36%   82.52%   +0.16%     
- Complexity     2134     2141       +7     
============================================
  Files           349      349              
  Lines          6056     6056              
  Branches       1108     1108              
============================================
+ Hits           4988     4998      +10     
+ Misses          489      479      -10     
  Partials        579      579
Impacted Files Coverage Δ Complexity Δ
...turbosch/detekt/formatting/wrappers/Indentation.kt 100% <ø> (+44.44%) 4 <0> (+2) ⬆️
...etekt/formatting/wrappers/ParameterListWrapping.kt 100% <ø> (+42.85%) 4 <0> (+2) ⬆️
...ch/detekt/formatting/wrappers/MaximumLineLength.kt 88.88% <ø> (+33.33%) 5 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a8555...0cdb5ae. Read the comment docs.

Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@arturbosch arturbosch merged commit 4c1158a into detekt:master Feb 18, 2020
@arturbosch arturbosch added this to the 1.6.0 milestone Feb 18, 2020
@schalkms schalkms deleted the formatting-rule-config-test branch February 26, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants