Skip to content

Don't normalize file content twice #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Don't normalize file content twice #2354

merged 1 commit into from
Feb 18, 2020

Conversation

3flex
Copy link
Member

@3flex 3flex commented Feb 16, 2020

File content is normalised in createKtFile so there's no need to normalise content before passing the string to that function.

@codecov-io
Copy link

codecov-io commented Feb 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b017b77). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2354   +/-   ##
=========================================
  Coverage          ?   82.35%           
  Complexity        ?     2134           
=========================================
  Files             ?      349           
  Lines             ?     6057           
  Branches          ?     1110           
=========================================
  Hits              ?     4988           
  Misses            ?      489           
  Partials          ?      580
Impacted Files Coverage Δ Complexity Δ
...lin/io/gitlab/arturbosch/detekt/core/KtCompiler.kt 84.61% <100%> (ø) 6 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b017b77...f2d0312. Read the comment docs.

@arturbosch arturbosch added this to the 1.6.0 milestone Feb 17, 2020
@arturbosch arturbosch merged commit fdbf376 into master Feb 18, 2020
@arturbosch arturbosch deleted the normalize-once branch February 18, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants