Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include options to better meet requirements for utility files #2355

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Feb 16, 2020

@arturbosch arturbosch force-pushed the matching-declaration-config-options branch from a7f265f to 680de40 Compare February 16, 2020 23:22
@codecov-io
Copy link

codecov-io commented Feb 16, 2020

Codecov Report

Merging #2355 into master will decrease coverage by <.01%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2355      +/-   ##
============================================
- Coverage      82.9%   82.89%   -0.01%     
+ Complexity     2153     2152       -1     
============================================
  Files           351      351              
  Lines          6054     6063       +9     
  Branches       1106     1106              
============================================
+ Hits           5019     5026       +7     
  Misses          466      466              
- Partials        569      571       +2
Impacted Files Coverage Δ Complexity Δ
...sch/detekt/rules/naming/MatchingDeclarationName.kt 87.5% <84.21%> (-5.84%) 6 <1> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa3b4d...90fdcf8. Read the comment docs.

@arturbosch arturbosch force-pushed the matching-declaration-config-options branch from 680de40 to 2eedb5e Compare February 26, 2020 08:45
@arturbosch arturbosch added this to the 1.6.0 milestone Feb 26, 2020
@arturbosch
Copy link
Member Author

I've removed the ignoreDataClasses property for now.
In a later update we can take data, inline and enum classes into account.

@arturbosch arturbosch force-pushed the matching-declaration-config-options branch from 2eedb5e to 90fdcf8 Compare February 26, 2020 09:03
@arturbosch arturbosch merged commit deb616e into master Feb 26, 2020
@arturbosch arturbosch deleted the matching-declaration-config-options branch February 26, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants