Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new ConfigValidator extensions - #2285 #2356

Merged
merged 2 commits into from
Feb 21, 2020

Conversation

arturbosch
Copy link
Member

@arturbosch arturbosch commented Feb 17, 2020

  • Do not fail by default for custom rule set configuration properties
  • Allow users to validate their config properties

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b017b77). Click here to learn what that means.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2356   +/-   ##
=========================================
  Coverage          ?   82.55%           
  Complexity        ?     2139           
=========================================
  Files             ?      351           
  Lines             ?     6065           
  Branches          ?     1111           
=========================================
  Hits              ?     5007           
  Misses            ?      479           
  Partials          ?      579
Impacted Files Coverage Δ Complexity Δ
...tlab/arturbosch/detekt/cli/config/InvalidConfig.kt 100% <ø> (ø) 1 <0> (?)
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Main.kt 36% <ø> (ø) 6 <0> (?)
.../io/gitlab/arturbosch/detekt/cli/runners/Runner.kt 92.3% <ø> (ø) 12 <0> (?)
...ekt/cli/config/DefaultPropertiesConfigValidator.kt 100% <100%> (ø) 1 <1> (?)
...b/arturbosch/detekt/cli/config/ConfigValidators.kt 72.72% <72.72%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b017b77...94b89b3. Read the comment docs.

@arturbosch arturbosch changed the title Include default config validation excludes for plugin rule sets - #2285 Introduce new ConfigValidator extensions - #2285 Feb 19, 2020
@arturbosch arturbosch marked this pull request as ready for review February 19, 2020 21:29
@arturbosch arturbosch added this to the 1.6.0 milestone Feb 21, 2020
@arturbosch arturbosch merged commit d0d41cf into master Feb 21, 2020
@arturbosch arturbosch deleted the default-excludes-for-plugins branch February 21, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants